sv/IronOS
1
0
Fork 0
forked from me/IronOS
Code Pull Requests Activity

Merge pull request #2048 from Ralim/pinecilv2-i2c-rework

Browse Source 
Drop critical section on I2C
This commit is contained in:
Ben V. Brown
2025-01-11 10:04:33 +11:00
committed by GitHub
parent 42fb9e1105 a3082c389e
commit b401dc8264
2 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/Core/BSP/Pinecilv2/I2C_Wrapper.cpp
View File

@@ -40,10 +40,7 @@ bool FRToSI2C::Mem_Read(uint16_t DevAddress, uint16_t read_address, uint8_t *p_b
i2cCfg.data = p_buffer;
i2cCfg.subAddrSize = 1; // one byte address
taskENTER_CRITICAL();
/* --------------- */
err = I2C_MasterReceiveBlocking(I2C0_ID, &i2cCfg);
taskEXIT_CRITICAL();
err = I2C_MasterReceiveBlocking(I2C0_ID, &i2cCfg);
bool res = err == SUCCESS;
if (!res) {
I2C_Unstick();
@@ -65,10 +62,7 @@ bool FRToSI2C::Mem_Write(uint16_t DevAddress, uint16_t MemAddress, uint8_t *p_bu
i2cCfg.data = p_buffer;
i2cCfg.subAddrSize = 1; // one byte address
taskENTER_CRITICAL();
/* --------------- */
err = I2C_MasterSendBlocking(I2C0_ID, &i2cCfg);
taskEXIT_CRITICAL();
err = I2C_MasterSendBlocking(I2C0_ID, &i2cCfg);
bool res = err == SUCCESS;
if (!res) {
I2C_Unstick();

2
source/Core/Threads/UI/logic/utils/SolderingCommon.cpp
View File

@@ -39,8 +39,6 @@ bool checkExitSoldering(void) {
}
#endif
// If we have tripped thermal runaway, turn off heater and show warning
return false;
}