* Code Cleanup (#158) * print coverage report * create sonar-project property file * install all py dependencies in one step * code cleanup * reduce cognitive complexity * do not build on *.yml changes * optimise versionstring handling (#159) - Reading the version string from the image updates it even if the image is re-pulled without re-deployment * fix linter warning * exclude *.pyi filese * ignore some rules for tests * cleanup (#160) * Sonar qube 3 (#163) fix SonarQube warnings in modbus.py * Sonar qube 3 (#164) * fix SonarQube warnings * Sonar qube 3 (#165) * cleanup * Add support for TSUN Titan inverter Fixes #161 * fix SonarQube warnings * fix error * rename field "config" * SonarQube reads flake8 output * don't stop on flake8 errors * flake8 scan only app/src for SonarQube * update flake8 run * ignore flake8 C901 * cleanup * fix linter warnings * ignore changed *.yml files * read sensor list solarman data packets * catch 'No route to' error and log only in debug mode * fix unit tests * add sensor_list configuration * adapt unit tests * fix SonarQube warnings * Sonar qube 3 (#166) * add unittests for mqtt.py * add mock * move test requirements into a file * fix unit tests * fix formating * initial version * fix SonarQube warning * Sonar qube 4 (#169) * add unit test for inverter.py * fix SonarQube warning * Sonar qube 5 (#170) * fix SonarLints warnings * use random IP adresses for unit tests * Docker: The description ist missing (#171) Fixes #167 * S allius/issue167 (#172) * cleanup * Sonar qube 6 (#174) * test class ModbusConn * Sonar qube 3 (#178) * add more unit tests * GEN3: don't crash on overwritten msg in the receive buffer * improve test coverage und reduce test delays * reduce cognitive complexity * fix merge * fix merge conflikt * fix merge conflict * S allius/issue182 (#183) * GEN3: After inverter firmware update the 'Unknown Msg Type' increases continuously Fixes #182 * add support for Controller serial no and MAC * test hardening * GEN3: add support for new messages of version 3 firmwares * bump libraries to latest versions - bump aiomqtt to version 2.3.0 - bump aiohttp to version 3.10.5 * improve test coverage * reduce cognective complexity * fix target preview * remove dubbled fixtures * increase test coverage * Update README.md (#185) update badges * S allius/issue186 (#187) * Parse more values in Server Mode Fixes #186 * read OUTPUT_COEFFICIENT and MAC_ADDR in SrvMode * fix unit test * increase test coverage * S allius/issue186 (#188) * increase test coverage * update changelog * add dokumentation * change default config * Update README.md (#189) Config file is now foldable * GEN3: Invalid Contact Info Msg (#192) Fixes #191 * Refactoring async stream (#194) * GEN3: Invalid Contact Info Msg Fixes #191 * introduce ifc with FIFOs * add object factory * use AsyncIfc class with FIFO * declare more methods as classmethods * - refactoring - remove _forward_buffer - make async_write private * remove _forward_buffer * refactoring * avoid mqtt handling for invalid serial numbers * add two more callbacks * FIX update_header_cb handling * split AsyncStream in two classes * split ConnectionG3(P) in server and client class * update class diagramm * refactor server creation * remove duplicated imports * reduce code duplication * move StremPtr instances into Inverter class * resolution of connection classes - remove ConnectionG3Client - remove ConnectionG3Server - remove ConnectionG3PClient - remove ConnectionG3PServer * fix server connections * fix client loop closing * don't overwrite self.remote in constructor * update class diagramm * fixes - fixes null pointer accesses - initalize AsyncStreamClient with proper StreamPtr instance * add close callback * refactor close handling * remove connection classes * move more code into InverterBase class * remove test_inverter_base.py * add abstract inverter interface class * initial commit * fix sonar qube warnings * rename class Inverter into Proxy * fix typo * move class InverterIfc into a separate file * add more testcases * use ProtocolIfc class * add unit tests for AsyncStream class * icrease test coverage * reduce cognitive complexity * increase test coverage * increase tes coverage * simplify heartbeat handler * remove obsolete tx_get method * add more unittests * update changelog * remove __del__ method for proper gc runs * check releasing of ModbusConn instances * call garbage collector to release unreachable objs * decrease ref counter after the with block * S allius/issue196 (#198) * fix healthcheck - on infrastructure with IPv6 support localhost might be resolved to an IPv6 adress. Since the proxy only support IPv4 for now, we replace localhost by 127.0.0.1, to fix this * merge from main
256 lines
8.5 KiB
Python
256 lines
8.5 KiB
Python
# test_with_pytest.py
|
|
import pytest
|
|
import asyncio
|
|
import aiomqtt
|
|
import logging
|
|
|
|
from mock import patch, Mock
|
|
from app.src.async_stream import AsyncIfcImpl
|
|
from app.src.singleton import Singleton
|
|
from app.src.mqtt import Mqtt
|
|
from app.src.modbus import Modbus
|
|
from app.src.gen3plus.solarman_v5 import SolarmanV5
|
|
from app.src.config import Config
|
|
|
|
|
|
pytest_plugins = ('pytest_asyncio',)
|
|
|
|
@pytest.fixture(scope="module", autouse=True)
|
|
def module_init():
|
|
Singleton._instances.clear()
|
|
yield
|
|
|
|
@pytest.fixture(scope="module")
|
|
def test_port():
|
|
return 1883
|
|
|
|
@pytest.fixture(scope="module")
|
|
def test_hostname():
|
|
# if getenv("GITHUB_ACTIONS") == "true":
|
|
# return 'mqtt'
|
|
# else:
|
|
return 'test.mosquitto.org'
|
|
|
|
@pytest.fixture
|
|
def config_mqtt_conn(test_hostname, test_port):
|
|
Config.act_config = {'mqtt':{'host': test_hostname, 'port': test_port, 'user': '', 'passwd': ''},
|
|
'ha':{'auto_conf_prefix': 'homeassistant','discovery_prefix': 'homeassistant', 'entity_prefix': 'tsun'}
|
|
}
|
|
|
|
@pytest.fixture
|
|
def config_no_conn(test_port):
|
|
Config.act_config = {'mqtt':{'host': "", 'port': test_port, 'user': '', 'passwd': ''},
|
|
'ha':{'auto_conf_prefix': 'homeassistant','discovery_prefix': 'homeassistant', 'entity_prefix': 'tsun'}
|
|
}
|
|
|
|
@pytest.fixture
|
|
def spy_at_cmd():
|
|
conn = SolarmanV5(('test.local', 1234), server_side=True, client_mode= False, ifc=AsyncIfcImpl())
|
|
conn.node_id = 'inv_2/'
|
|
with patch.object(conn, 'send_at_cmd', wraps=conn.send_at_cmd) as wrapped_conn:
|
|
yield wrapped_conn
|
|
conn.close()
|
|
|
|
@pytest.fixture
|
|
def spy_modbus_cmd():
|
|
conn = SolarmanV5(('test.local', 1234), server_side=True, client_mode= False, ifc=AsyncIfcImpl())
|
|
conn.node_id = 'inv_1/'
|
|
with patch.object(conn, 'send_modbus_cmd', wraps=conn.send_modbus_cmd) as wrapped_conn:
|
|
yield wrapped_conn
|
|
conn.close()
|
|
|
|
@pytest.fixture
|
|
def spy_modbus_cmd_client():
|
|
conn = SolarmanV5(('test.local', 1234), server_side=False, client_mode= False, ifc=AsyncIfcImpl())
|
|
conn.node_id = 'inv_1/'
|
|
with patch.object(conn, 'send_modbus_cmd', wraps=conn.send_modbus_cmd) as wrapped_conn:
|
|
yield wrapped_conn
|
|
conn.close()
|
|
|
|
def test_native_client(test_hostname, test_port):
|
|
"""Sanity check: Make sure the paho-mqtt client can connect to the test
|
|
MQTT server.
|
|
"""
|
|
|
|
import paho.mqtt.client as mqtt
|
|
import threading
|
|
|
|
c = mqtt.Client()
|
|
c.loop_start()
|
|
try:
|
|
# Just make sure the client connects successfully
|
|
on_connect = threading.Event()
|
|
c.on_connect = Mock(side_effect=lambda *_: on_connect.set())
|
|
c.connect_async(test_hostname, test_port)
|
|
assert on_connect.wait(5)
|
|
finally:
|
|
c.loop_stop()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_mqtt_no_config(config_no_conn):
|
|
_ = config_no_conn
|
|
assert asyncio.get_running_loop()
|
|
|
|
on_connect = asyncio.Event()
|
|
async def cb():
|
|
on_connect.set()
|
|
|
|
try:
|
|
m = Mqtt(cb)
|
|
assert m.task
|
|
await asyncio.sleep(0)
|
|
assert not on_connect.is_set()
|
|
try:
|
|
await m.publish('homeassistant/status', 'online')
|
|
assert False
|
|
except Exception:
|
|
pass
|
|
except TimeoutError:
|
|
assert False
|
|
finally:
|
|
await m.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_mqtt_connection(config_mqtt_conn):
|
|
_ = config_mqtt_conn
|
|
assert asyncio.get_running_loop()
|
|
|
|
on_connect = asyncio.Event()
|
|
async def cb():
|
|
on_connect.set()
|
|
|
|
try:
|
|
m = Mqtt(cb)
|
|
assert m.task
|
|
assert await asyncio.wait_for(on_connect.wait(), 5)
|
|
# await asyncio.sleep(1)
|
|
assert 0 == m.ha_restarts
|
|
await m.publish('homeassistant/status', 'online')
|
|
except TimeoutError:
|
|
assert False
|
|
finally:
|
|
await m.close()
|
|
await m.publish('homeassistant/status', 'online')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_msg_dispatch(config_mqtt_conn, spy_modbus_cmd):
|
|
_ = config_mqtt_conn
|
|
spy = spy_modbus_cmd
|
|
try:
|
|
m = Mqtt(None)
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/rated_load', payload= b'2', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_awaited_once_with(Modbus.WRITE_SINGLE_REG, 0x2008, 2, logging.INFO)
|
|
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/out_coeff', payload= b'100', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_awaited_once_with(Modbus.WRITE_SINGLE_REG, 0x202c, 1024, logging.INFO)
|
|
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/out_coeff', payload= b'50', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_awaited_once_with(Modbus.WRITE_SINGLE_REG, 0x202c, 512, logging.INFO)
|
|
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/modbus_read_regs', payload= b'0x3000, 10', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_awaited_once_with(Modbus.READ_REGS, 0x3000, 10, logging.INFO)
|
|
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/modbus_read_inputs', payload= b'0x3000, 10', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_awaited_once_with(Modbus.READ_INPUTS, 0x3000, 10, logging.INFO)
|
|
|
|
finally:
|
|
await m.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_msg_dispatch_err(config_mqtt_conn, spy_modbus_cmd):
|
|
_ = config_mqtt_conn
|
|
spy = spy_modbus_cmd
|
|
try:
|
|
m = Mqtt(None)
|
|
# test out of range param
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/out_coeff', payload= b'-1', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_not_called()
|
|
|
|
# test unknown node_id
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_2/out_coeff', payload= b'2', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_not_called()
|
|
|
|
# test invalid fload param
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/out_coeff', payload= b'2, 3', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_not_called()
|
|
|
|
spy.reset_mock()
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/modbus_read_regs', payload= b'0x3000, 10, 7', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_not_called()
|
|
finally:
|
|
await m.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_msg_ignore_client_conn(config_mqtt_conn, spy_modbus_cmd_client):
|
|
'''don't call function if connnection is not in server mode'''
|
|
_ = config_mqtt_conn
|
|
spy = spy_modbus_cmd_client
|
|
try:
|
|
m = Mqtt(None)
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/rated_load', payload= b'2', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_not_called()
|
|
finally:
|
|
await m.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_ha_reconnect(config_mqtt_conn):
|
|
_ = config_mqtt_conn
|
|
on_connect = asyncio.Event()
|
|
async def cb():
|
|
on_connect.set()
|
|
|
|
try:
|
|
m = Mqtt(cb)
|
|
msg = aiomqtt.Message(topic= 'homeassistant/status', payload= b'offline', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
assert not on_connect.is_set()
|
|
|
|
msg = aiomqtt.Message(topic= 'homeassistant/status', payload= b'online', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
assert on_connect.is_set()
|
|
|
|
finally:
|
|
await m.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_ignore_unknown_func(config_mqtt_conn):
|
|
'''don't dispatch for unknwon function names'''
|
|
_ = config_mqtt_conn
|
|
try:
|
|
m = Mqtt(None)
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_1/rated_load', payload= b'2', qos= 0, retain = False, mid= 0, properties= None)
|
|
for _ in m.each_inverter(msg, 'unkown_fnc'):
|
|
assert False
|
|
finally:
|
|
await m.close()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_at_cmd_dispatch(config_mqtt_conn, spy_at_cmd):
|
|
_ = config_mqtt_conn
|
|
spy = spy_at_cmd
|
|
try:
|
|
m = Mqtt(None)
|
|
msg = aiomqtt.Message(topic= 'tsun/inv_2/at_cmd', payload= b'AT+', qos= 0, retain = False, mid= 0, properties= None)
|
|
await m.dispatch_msg(msg)
|
|
spy.assert_awaited_once_with('AT+')
|
|
|
|
finally:
|
|
await m.close()
|