From 98ef252bb0167c7eec4db6e83194d7371bf52e2b Mon Sep 17 00:00:00 2001 From: Stefan Allius Date: Mon, 20 May 2024 18:51:55 +0200 Subject: [PATCH] don't forward invalid MODBUS responses --- app/src/gen3plus/solarman_v5.py | 2 +- app/tests/test_solarman.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/gen3plus/solarman_v5.py b/app/src/gen3plus/solarman_v5.py index a53769a..f9231eb 100644 --- a/app/src/gen3plus/solarman_v5.py +++ b/app/src/gen3plus/solarman_v5.py @@ -467,7 +467,7 @@ class SolarmanV5(Message): if inv_update: self.__build_model_name() - return + return self.__forward_msg() def msg_hbeat_ind(self): diff --git a/app/tests/test_solarman.py b/app/tests/test_solarman.py index e339412..1092520 100644 --- a/app/tests/test_solarman.py +++ b/app/tests/test_solarman.py @@ -1489,7 +1489,7 @@ def test_msg_modbus_invalid(ConfigTsunInv1, MsgModbusInvalid): m.read() # read complete msg, and dispatch msg assert not m.header_valid # must be invalid, since msg was handled and buffer flushed assert m.msg_count == 1 - assert m._forward_buffer==MsgModbusInvalid + assert m._forward_buffer==b'' assert m._send_buffer==b'' assert m.db.stat['proxy']['Unknown_Ctrl'] == 0 assert m.db.stat['proxy']['Modbus_Command'] == 0