From 6b3918797b4935e5c05fae85066a3f3a96169fed Mon Sep 17 00:00:00 2001
From: Stefan Allius <122395479+s-allius@users.noreply.github.com>
Date: Tue, 18 Jun 2024 22:02:39 +0200
Subject: [PATCH] S allius/issue102 (#103)

* hotfix: don't send two MODBUS commands together

* Update README.md

Exchange logger fw version with the real inverter fw version in the compatibility table

* Update python-app.yml

run also on pushes to issue branches
fix name for issues branches
---
 .github/workflows/python-app.yml | 2 +-
 README.md                        | 2 +-
 app/src/scheduler.py             | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml
index 2c7031b..f51ae3d 100644
--- a/.github/workflows/python-app.yml
+++ b/.github/workflows/python-app.yml
@@ -5,7 +5,7 @@ name: Python application
 
 on:
   push:
-    branches: [ "main", "dev-*" ]
+    branches: [ "main", "dev-*", "*/issue*" ]
     paths-ignore:
     - '**.md' # Do no build on *.md changes
     - '**.yml' # Do no build on *.yml changes
diff --git a/README.md b/README.md
index de53248..67a6ead 100644
--- a/README.md
+++ b/README.md
@@ -226,7 +226,7 @@ In the following table you will find an overview of which inverter model has bee
 A combination with a red question mark should work, but I have not checked it in detail.
 
 <table align="center">
-  <tr><th align="center">Micro Inverter Model</th><th align="center">Fw. 1.00.06</th><th align="center">Fw. 1.00.17</th><th align="center">Fw. 1.00.20</th><th align="center">Fw. 1.1.00.0B</th></tr>
+  <tr><th align="center">Micro Inverter Model</th><th align="center">Fw. 1.00.06</th><th align="center">Fw. 1.00.17</th><th align="center">Fw. 1.00.20</th><th align="center">Fw. 4.0.10</th></tr>
   <tr><td>GEN3 micro inverters (single MPPT):<br>MS300, MS350, MS400<br>MS400-D</td><td align="center">❓</td><td align="center">❓</td><td align="center">❓</td><td align="center">➖</td></tr>
   <tr><td>GEN3 micro inverters (dual MPPT):<br>MS600, MS700, MS800<br>MS600-D, MS800-D</td><td align="center">✔️</td><td align="center">✔️</td><td align="center">✔️</td><td align="center">➖</td></tr>
   <tr><td>GEN3 PLUS micro inverters:<br>MS1600, MS1800, MS2000<br>MS2000-D</td><td align="center">➖</td><td align="center">➖</td><td align="center">➖</td><td align="center">✔️</td></tr>
diff --git a/app/src/scheduler.py b/app/src/scheduler.py
index 785bbcd..6f54b6d 100644
--- a/app/src/scheduler.py
+++ b/app/src/scheduler.py
@@ -41,7 +41,7 @@ class Schedule:
                 fnc = getattr(m, "send_modbus_cmd", None)
                 if callable(fnc):
                     await fnc(Modbus.READ_REGS, 0x3008, 21, logging.DEBUG)
-                    if 0 == (cls.count % 30):
-                        # logging.info("Regular Modbus Status request")
-                        await fnc(Modbus.READ_REGS, 0x2007, 2, logging.DEBUG)
+                    # if 0 == (cls.count % 30):
+                    #     # logging.info("Regular Modbus Status request")
+                    #     await fnc(Modbus.READ_REGS, 0x2007, 2, logging.DEBUG)
         cls.count += 1