From 3a94afb48d0d3f012a1ef1c3397ca728a0a73462 Mon Sep 17 00:00:00 2001
From: Stefan Allius <stefan.allius@t-online.de>
Date: Fri, 4 Oct 2024 01:50:24 +0200
Subject: [PATCH] fix sonar qube warnings

---
 app/src/inverter_base.py | 2 +-
 app/src/server.py        | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/src/inverter_base.py b/app/src/inverter_base.py
index bd7c700..da062d3 100644
--- a/app/src/inverter_base.py
+++ b/app/src/inverter_base.py
@@ -48,7 +48,7 @@ class InverterIfc(metaclass=AbstractIterMeta):
         pass  # pragma: no cover
 
     @abstractmethod
-    async def disc(self, shutdown_started=False) -> None: 
+    async def disc(self, shutdown_started=False) -> None:
         pass  # pragma: no cover
 
     @abstractmethod
diff --git a/app/src/server.py b/app/src/server.py
index 0ff5202..1cca411 100644
--- a/app/src/server.py
+++ b/app/src/server.py
@@ -6,6 +6,7 @@ from asyncio import StreamReader, StreamWriter
 from aiohttp import web
 from logging import config  # noqa F401
 from inverter import Inverter
+from inverter_base import InverterIfc
 from gen3.inverter_g3 import InverterG3
 from gen3plus.inverter_g3p import InverterG3P
 from scheduler import Schedule
@@ -37,7 +38,7 @@ async def healthy(request):
 
     if proxy_is_up:
         # logging.info('web reqeust healthy()')
-        for inverter in Inverter:
+        for inverter in InverterIfc:
             try:
                 res = inverter.healthy()
                 if not res:
@@ -86,7 +87,7 @@ async def handle_shutdown(web_task):
     #
     # first, disc all open TCP connections gracefully
     #
-    for inverter in Inverter:
+    async for inverter in InverterIfc:
         await inverter.disc(True)
 
     logging.info('Proxy disconnecting done')