sv/tsun-gen3-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve Modbus logging

Browse Source
This commit is contained in:
Stefan Allius
2024-05-13 22:48:44 +02:00
parent 6877465915
commit 14425da5fa
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/modbus.py
View File

@@ -86,11 +86,11 @@ class Modbus():
# logging.info(f'recv_req: first byte modbus:{buf[0]} len:{len(buf)}') # logging.info(f'recv_req: first byte modbus:{buf[0]} len:{len(buf)}')
if not self.check_crc(buf): if not self.check_crc(buf):
self.err = 1 self.err = 1
logging.error('Modbus: CRC error') logging.error('Modbus recv: CRC error')
return False return False
if buf[0] != self.INV_ADDR: if buf[0] != self.INV_ADDR:
self.err = 2 self.err = 2
logging.info(f'Modbus: Wrong addr{buf[0]}') logging.info(f'Modbus recv: Wrong addr{buf[0]}')
return False return False
res = struct.unpack_from('>BHH', buf, 1) res = struct.unpack_from('>BHH', buf, 1)
self.last_fcode = res[0] self.last_fcode = res[0]
@@ -103,11 +103,11 @@ class Modbus():
Generator[tuple[str, bool], None, None]: Generator[tuple[str, bool], None, None]:
# logging.info(f'recv_resp: first byte modbus:{buf[0]} len:{len(buf)}') # logging.info(f'recv_resp: first byte modbus:{buf[0]} len:{len(buf)}')
if not self.check_crc(buf): if not self.check_crc(buf):
logging.error('Modbus: CRC error') logging.error('Modbus resp: CRC error')
self.err = 1 self.err = 1
return return
if buf[0] != self.INV_ADDR: if buf[0] != self.INV_ADDR:
logging.info(f'Modbus: Wrong addr {buf[0]}') logging.info(f'Modbus resp: Wrong addr {buf[0]}')
self.err = 2 self.err = 2
return return
if buf[1] != self.last_fcode: if buf[1] != self.last_fcode: