From 17e82105b14620d20b653847b1e8f6ecac2aff76 Mon Sep 17 00:00:00 2001
From: "Ben V. Brown" <ralim@ralimtek.com>
Date: Sun, 12 Sep 2021 14:47:44 +1000
Subject: [PATCH] Give all languages a unique ID

---
 Translations/make_translation.py      | 13 +++++++++++++
 Translations/make_translation_test.py | 19 +++++++++++++++++++
 2 files changed, 32 insertions(+)
 mode change 100644 => 100755 Translations/make_translation_test.py

diff --git a/Translations/make_translation.py b/Translations/make_translation.py
index 8c6274c2..de4028d5 100755
--- a/Translations/make_translation.py
+++ b/Translations/make_translation.py
@@ -3,6 +3,7 @@
 import argparse
 import functools
 import json
+import hashlib
 import logging
 import os
 import pickle
@@ -41,6 +42,16 @@ def load_json(filename: str, skip_first_line: bool) -> dict:
         return json.loads(f.read())
 
 
+def get_language_unqiue_id(language_ascii_name: str):
+    """
+    Given a language code, it will return a unique (enough) uint16_t id code
+    When we have a collision here we can tweak this, but language list should be fairly stable from now on
+    """
+    return (
+        int(hashlib.sha1(language_ascii_name.encode("utf-8")).hexdigest(), 16) % 0xFFFF
+    )
+
+
 def read_translation(json_root: Union[str, Path], lang_code: str) -> dict:
     filename = f"translation_{lang_code}.json"
 
@@ -868,10 +879,12 @@ def write_languages(
         f.write("const LanguageMeta LanguageMetas[] = {\n")
         for lang in data.langs:
             lang_code = lang["languageCode"]
+            lang_id = get_language_unqiue_id(lang_code)
             f.write(
                 "  {\n"
                 # NOTE: Cannot specify C99 designator here due to GCC (g++) bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55227
                 f'    /* .code = */ "{lang_code}",\n'
+                f"    .uniqueID = {lang_id},\n"
                 f"    .translation_data = reinterpret_cast<const uint8_t *>(&translation_{lang_code}),\n"
                 f"    .translation_size = sizeof(translation_{lang_code}),\n"
                 f"    .translation_is_compressed = false,\n"
diff --git a/Translations/make_translation_test.py b/Translations/make_translation_test.py
old mode 100644
new mode 100755
index 9b2d1ba4..6d77b04b
--- a/Translations/make_translation_test.py
+++ b/Translations/make_translation_test.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python3
+import json
+import os
 import unittest
 
 
@@ -30,6 +32,23 @@ class TestMakeTranslation(unittest.TestCase):
         self.assertEqual(bytes_to_c_hex(b"\x00"), "0x00,")
         self.assertEqual(bytes_to_c_hex(b"\xF1\xAB"), "0xF1, 0xAB,")
 
+    def test_no_language_id_collisions(self):
+        """
+        Asserting that we have no language collisions and that the has works ok
+        """
+        from make_translation import get_language_unqiue_id
+
+        seen_ids = []
+        for filename in os.listdir("."):
+            if filename.endswith(".json") and filename.startswith("translation_"):
+                with open(filename) as f:
+                    data = json.loads(f.read())
+                    lang_code = data.get("languageCode")
+                    self.assertNotEqual(lang_code, None)
+                    id = get_language_unqiue_id(lang_code)
+                    self.assertFalse(id in seen_ids)
+                    seen_ids.append(id)
+
 
 if __name__ == "__main__":
     unittest.main()